Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: read pyth token mint from staking program in initialize pool #518

Merged
merged 4 commits into from
Sep 4, 2024
Merged

feat: read pyth token mint from staking program in initialize pool #518

merged 4 commits into from
Sep 4, 2024

Conversation

keyvankhademi
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Sep 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 3:27pm
staking-devnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 3:27pm

guibescos
guibescos reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@guibescos guibescos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we needed this on devnet, but is this a feature that we want to have?? It kind of breaks the code if pyth_token_mint gets updated mid reward program

@keyvankhademi
Copy link
Contributor Author

I was thinking it's better to be there in case we made a similar mistake. But I figured out a better way to avoid this mistake by setting the pyth token mint from the staking account.

@keyvankhademi keyvankhademi changed the title feat: add update pyth token mint instruction feat: read pyth token mint from staking program in initialize pool Sep 4, 2024
guibescos
guibescos approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@guibescos guibescos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@keyvankhademi keyvankhademi merged commit dcfc1e8 into main Sep 4, 2024
7 checks passed
@keyvankhademi keyvankhademi deleted the update-mint branch September 4, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guibescos guibescos guibescos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keyvankhademi @guibescos