include permissions account in instructions #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ayazabbas
commented
Jun 27, 2024
•
ayazabbas
commented
- include permissions account in instructions
- re-order operations in sync to ensure permissions account is setup before other instructions execute
- update tests
- delete oracle file from git
- download latest oracle from pyth-client repo for testing
- use pyright and pyflakes as we do in other projects
- minor type changes to satisfy linting
update tests download latest oracle for tests
thmzlt
approved these changes
Jun 27, 2024
program_admin/__init__.py
Outdated
| await self.send_transaction( | ||
| authority_instructions, authority_signers | ||
| ) | ||
| else: |
There was a problem hiding this comment.
I see you removed the optional wrapper around ref auth permissions, but here it implies that it can be nil, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.