Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow passing a custom ArqRedis class to create_pool #495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jvllmr
Copy link

@jvllmr jvllmr commented Jan 19, 2025

I would like to extend the functionality of the ArqRedis in one of my projects, but I also want to use the original create_pool function. It would be great if the create_pool function would accept a custom class which extends ArqRedis

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
arq/connections.py 40.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
- Coverage   96.27%   96.10%   -0.17%     
==========================================
  Files          11       11              
  Lines        1074     1079       +5     
  Branches      209      190      -19     
==========================================
+ Hits         1034     1037       +3     
- Misses         19       21       +2     
  Partials       21       21              
Files with missing lines Coverage Δ
arq/connections.py 87.50% <40.00%> (-2.57%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a911f3...c1ce72c. Read the comment docs.

@jvllmr jvllmr force-pushed the create-pool-custom-class branch 3 times, most recently from f7be1f3 to dcba348 Compare January 19, 2025 17:23
@jvllmr jvllmr force-pushed the create-pool-custom-class branch from dcba348 to c1ce72c Compare January 19, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants