Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rearrange code to make PyPy testing happier #59

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Feb 15, 2024

PyPy testing has a check that the file src/c/test_c.py is properly synced to the PyPy version. It checks only code below the # __________________ marker. The _assert_unraisable function added in #24 needs a bit of work to support all the python versions supported by PyPy (specifically, PyPy still uses python2.7) so it should appear above the marker.

The change should be harmless in this repo since it is "only" a rearrangement of code.

cc @arigo

@arigo
Copy link
Contributor

arigo commented Feb 15, 2024

A bit confused: I thought that the check you mention is disabled by now. If it isn't, then is this commit enough? I had to do a couple more tweaks, like disabling the tests that end up calling this function... You are you talking about pypy/module/_cffi_backend/test/_backend_tests.py, right? Not the other copy that ends up in extra_tests?

@mattip
Copy link
Contributor Author

mattip commented Feb 15, 2024

Yes, this is for the untranslated PyPy _cffi_backend tests. The test_file check is still active (and failing) on PyPy.

@arigo
Copy link
Contributor

arigo commented Feb 15, 2024

I'd consider skipping that test instead...

@mattip
Copy link
Contributor Author

mattip commented Feb 15, 2024

I could skip it. But on the other hand, this is a pretty simple change to allow the test to keep running.

@arigo arigo merged commit 640e89f into python-cffi:main Feb 15, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants