add Wavefront Handler #632
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Supersedes #480 |
|
Can you change the commit message to be relevant to what it is? also add testing? |
| @@ -376,7 +376,7 @@ def collect(self): | |||
| raise NotImplementedError() | |||
|
|
|||
| def publish(self, name, value, raw_value=None, precision=0, | |||
| metric_type='GAUGE', instance=None): | |||
| metric_type='GAUGE', instance=None, point_tags=None): | |||
There was a problem hiding this comment.
metric_tags would make more sense throughout.
| Send metrics to a Wavefront proxy | ||
| """ | ||
|
|
||
| RETRY = 3 |
There was a problem hiding this comment.
Please make this a config option.
| 'host': 'Wavefront proxy endpoint', | ||
| 'port': 'port on Wavefront proxy', | ||
| 'timeout': '', | ||
| 'format': '', |
There was a problem hiding this comment.
Can you add a description for these 2?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a repeat of a PR that's I'd previously had open for a very long time. It reached a point where rebasing from master was getting so messy that I chose to close it and generate a fresh, clean PR. Two new files and one minor change, in a single commit.
It adds support for a handler which sends multidimensional metrics to a Wavefront proxy. I've been using it in production for the best part of a year.