-
-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branding: improve IO resilience #2869
Commits on Dec 28, 2023
-
Branding: remove redundant error handling
If an error occurs during event fetch, the operation will now fail rather than skip the event or return an empty result. Skipping events may cause the branding to reset or change unexpectedly, which is not desired. If the bot cannot fetch all events, it should leave the existing branding assets intact.
Configuration menu - View commit details
-
Copy full SHA for ce7e2fd - Browse repository at this point
Copy the full SHA ce7e2fdView commit details -
Branding: fail if no event is active
If the bot cannot find an active event, it will try to find the fallback event. If the fallback event cannot be found either, it will now raise an error. This should be an exceptional state that cannot be recovered from. Synchronisation should be retried once the event setup is corrected.
Configuration menu - View commit details
-
Copy full SHA for 872c656 - Browse repository at this point
Copy the full SHA 872c656View commit details -
Branding: handle errors in calendar refresh
The event fetch may now fail. We handle the error in the calendar refresh command and present the user with the result.
Configuration menu - View commit details
-
Copy full SHA for 44bcfca - Browse repository at this point
Copy the full SHA 44bcfcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04f36e6 - Browse repository at this point
Copy the full SHA 04f36e6View commit details -
Branding: implement retry for server errors
Requests that fail due to a GitHub server error will now be retried.
Configuration menu - View commit details
-
Copy full SHA for 6c914de - Browse repository at this point
Copy the full SHA 6c914deView commit details -
Branding: do not invoke calendar after refresh
The bot will no longer automatically invoke the calendar view cmd after a cache refresh, as the cache refresh may fail.
Configuration menu - View commit details
-
Copy full SHA for 8d7ab36 - Browse repository at this point
Copy the full SHA 8d7ab36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 256d4cb - Browse repository at this point
Copy the full SHA 256d4cbView commit details -
No use for jitter in this case, as we don't make concurrent requests. Deterministic delays make more sense.
Configuration menu - View commit details
-
Copy full SHA for 5871218 - Browse repository at this point
Copy the full SHA 5871218View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d0f8ff - Browse repository at this point
Copy the full SHA 9d0f8ffView commit details