Undeprecate bookmark text command #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine in testing - is there anything I should be looking out for due to the changes made that weren't an exact copy? |
shtlrs
requested changes
Feb 28, 2023
Xithrius
added
area: backend
ChrisLovering
requested changes
Mar 4, 2023
ChrisLovering
requested changes
Mar 4, 2023
shtlrs
requested changes
Mar 19, 2023
6 tasks
ChrisLovering
added
status: waiting for author
Robin5605
added
status: needs review
ChrisLovering
requested changes
Jun 27, 2023
ChrisLovering
approved these changes
Jul 10, 2023
Xithrius
removed
the
status: needs review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Closes #1219
Closes #1179
Description
Undeprecated the
.bookmarkcommand, for reasons outlined in #1219. A majority of the code and logic was a straight copy paste from an older version of this repository, however some changes have had to be made to be compatible with the new version (as the rewrite to a context menu command had come with other code changes as well)Did you: