Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cases output in fun cog. #1457
base: main
Are you sure you want to change the base?
Add cases output in fun cog. #1457
Changes from all commits
90625a1
494f7c8
54a4622
a03b682
7bb7be4
d701255
1a4bc6a
731ab4d
ddaeb14
7ea86c9
1891f44
1432558
c599e70
3686fd3
67863ee
03d73f0
79a2afe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider making the variable name of the returned value more meaningful since the helper function was updated, and it's not immediately obvious that the
text
is actually alist
here.Note that this also applies to the
conversion_func
for other case commands :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about having a
*case
alias for all our case commands? It made sense to me during testing and was surprised it wasn't already added 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring would have to be updated to reflect the new function. Maybe the name too, up to you.