Improve formatting of ping and uptime commands #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wookie184
requested changes
May 30, 2024
There was a problem hiding this comment.
Thanks for the contribution.
The change to the uptime command looks fine to me but i'm not sure about the change to the ping command.
The linting is also not passing, if you look at https://github.com/python-discord/sir-lancebot/pull/1542/files you can see the issues, and you can use poetry run task lint locally to lint locally (and poetry run task precommit to set up precommit which will automatically check before you commit).
| @@ -20,7 +21,7 @@ async def ping(self, ctx: commands.Context) -> None: | |||
| embed = Embed( | |||
| title=":ping_pong: Pong!", | |||
| colour=Colours.bright_green, | |||
| description=f"Gateway Latency: {round(self.bot.latency * 1000)}ms", | |||
| description=f"Gateway Latency: `{round(self.bot.latency * 1000)}`ms", | |||
There was a problem hiding this comment.
I think both ways look fine, so I don't really think it's worth changing unless there's a good reason.
There was a problem hiding this comment.
Fair enough. I guess it's personal preference but definitely not a necessary change.
Xithrius
added
area: frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I changed the
uptimecommand to use a discord formatted timestamp, rather than formatting the start_time and sending it. This way you can see exactly when the bot started, in your own timezone.In addition, I also added some small formatting to the ping command, so the gateway ping is show in a tiny codeblock
like this.Did you: