-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve precisedelta
to better support rounding and float values.
#39
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 99.13% 96.54% -2.59%
==========================================
Files 9 9
Lines 690 694 +4
==========================================
- Hits 684 670 -14
- Misses 6 24 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment was marked as outdated.
This comment was marked as outdated.
e2f2dad
to
9ff98f7
Compare
(Force-pushed to clean up the commit history, since it was getting a bit long. 😅 Let me know if you'd like me to squash it down even more!) This PR now includes one of the commits from #19, to fix the root cause of #14. Thank you, @eldipa! 💜 I've also updated the description (#39 (comment)) to reflect all of the test cases that this PR adds and fixes. |
Fixes #14.
Fixes #20.
Changes proposed in this pull request
float
values inprecisedelta
.Test cases added to
test_precisedelta_custom_format
Test cases added to
test_precisedelta_multiple_units