Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internationalise intcomma for de_DE locale #49

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Internationalise intcomma for de_DE locale #49

merged 1 commit into from
Aug 25, 2022

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Aug 24, 2022

See discussion in #48.

Changes proposed in this pull request:

  • Add the proper thousands separator for the de_DE locale
  • Add a simple test

@hugovk hugovk added the changelog: Added For new features label Aug 24, 2022
@hugovk hugovk merged commit afdde01 into python-humanize:main Aug 25, 2022
@hugovk
Copy link
Member

hugovk commented Aug 25, 2022

Thanks!

@Luflosi Luflosi deleted the intcomma-de_DE branch August 25, 2022 09:39
@hugovk hugovk changed the title Internationalise intcomma for de_DE locale Internationalise intcomma for de_DE locale Sep 1, 2022
@mariovalney mariovalney mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog: Added For new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Luflosi @hugovk