Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check available features in Windows wheels #6847

Closed
wants to merge 7 commits into from

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Jan 1, 2023

Add test for #6701 and similar issues in earlier releases.
See successful run in my fork: https://github.com/nulano/Pillow/actions/runs/3815551828
See failed run detecting the #6701 issue for 9.3.0 release: https://github.com/nulano/Pillow/actions/runs/3815551828

This runs the tests and checks available features in a Windows Server Core Docker container similarly to how run_tests is run in the pillow-wheels repo. when building Linux/macOS wheels.

Marked as draft because:

  • PyPy tests work on my system, but there is no output on GHA except for an error. Fixed.
  • I'm not sure when this should be triggered. Running all tests twice for every push seems unnecessary (and takes extra 2min), but at least release wheels should be tested. I think the ideal option might be to run only when pushing a tag, but I think that might not get detected if there is a simultaneous push of the same commit to a branch.

Tests/test_imagegrab.py Outdated Show resolved Hide resolved
@radarhere
Copy link
Member

@nulano you may wish to consider this again as part of #7390 (comment)

@nulano
Copy link
Contributor Author

nulano commented Nov 20, 2023

Yes, I was planning to rebase this after writing that PR.

@nulano
Copy link
Contributor Author

nulano commented Nov 27, 2023

Closing in favor of #7580.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants