Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Use prepackaged NumPy to avoid slow source rebuilds #7282

Closed
wants to merge 1 commit into from
Closed

CI: Use prepackaged NumPy to avoid slow source rebuilds #7282

wants to merge 1 commit into from

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 12, 2023 •
edited
Loading

Fixes #7281.

Changes proposed in this pull request:

  • Don't install a newer NumPy, it causes slow rebuilds from source.
  • The prepackaged Cygwin NumPy is good enough.

@hugovk hugovk added the Testing label Jul 12, 2023
@hugovk hugovk changed the title Use prepackaged NumPy to avoid slow source rebuilds CI: Use prepackaged NumPy to avoid slow source rebuilds Jul 12, 2023
@hugovk
Copy link
Member Author

hugovk commented Jul 12, 2023

Hmm, failures for both Cygwin jobs:

Tests/test_numpy.py::test_roundtrip_eye[float] Fatal Python error: Segmentation fault

@radarhere
Copy link
Member

Yes. To my memory, this is unfortunately the reason that step exists - after encountering the segfault, it was added to "Try to get Cygwin workflow working."

@hugovk
Copy link
Member Author

hugovk commented Jul 14, 2023

Closing in favour of #7286.

@hugovk hugovk closed this Jul 14, 2023
@hugovk hugovk deleted the cygwin-numpy branch July 14, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cygwin CI not caching NumPy wheels
2 participants
@hugovk @radarhere