Raise UnidentifiedImageError when opening TIFF without dimensions #8535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8530
#8319 changed
to
Pillow/src/PIL/TiffImagePlugin.py
Lines 1436 to 1440 in 82199ef
This change seems reasonable, especially when you consider #4103.
However, if IMAGEWIDTH or IMAGELENGTH were missing, then
int(None)
previously raised a TypeError. TypeErrors are caught when opening imagesPillow/src/PIL/Image.py
Lines 3497 to 3506 in 82199ef
but the ValueErrors are not.
So this change inadvertently broke feeding a TIFF image to
ImageFile.Parser
, which relies on OSError (which UnidentifiedImageErrors are) to know that there isn't enough data yet.Pillow/src/PIL/ImageFile.py
Lines 468 to 473 in 82199ef
This PR changes the code to raise a TypeError again.