-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make --version
a non-global option
#143
Make --version
a non-global option
#143
Conversation
9fe1cee
to
faba585
Compare
self._io, | ||
self.application, | ||
namespace=self.argument("namespace"), | ||
definition=self.definition, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since application
only has the default definition, I ended up passing definition
as an extra argument, to retrieve it in _describe_application
.
Otherwise, the command would not display --version
option.
If there's a better way to handle that, I would gladly update that.
faba585
to
acddb23
Compare
I would prefer for the |
I share the same feeling, so I'm glad to read that. I'll rework the PR in that sense. |
@mkniewallner I think I am gonna delay this feature to the 1.1 release. Took a look into the code and in the current state, this is a non-trivial issue to add an app-level only option. I plan on refactoring and improving the parser past-1.0 and with what I have in mind, this should be much easier then. |
Makes sense. I didn't think it would require heavy changes when starting this PR, so entirely re-thinking the approach sounds better. |
Resolves #142.