feat: Added integration with the built-in logging package #440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the built-in
logging
package, as listed in the Cleo 3.0 writeup (#415 ). Implementation is of course subject to change, but I thought I'd get the ball rolling :)Here's what I did:
LogRecords
to acleo.io.outputs.output.Output
cleo.application.Application
which attaches anOutputHandler
to the root logger, and configures it to have a log level that is coherent with Cleo's one.Here are some open points that I know we need to discuss:
logging
handler have some sort of prefix or something to distinguish them from what is coming directly fromoutput.write_line()
?