Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing classifier to trio + add typing changelog #2811

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Oct 4, 2023

I think we can say the type hints for the library are complete, even if they are not entirely correct.

(Also I resorted the list to be alphabetical again...)

... Also I added a changelog entry.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #2811 (659cf43) into master (8b7da61) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2811   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files         115      115           
  Lines       17230    17230           
  Branches     3084     3084           
=======================================
  Hits        17081    17081           
  Misses        104      104           
  Partials       45       45           

@A5rocks A5rocks changed the title Add typing classifier to trio Add typing classifier to trio + add typing changelog Oct 4, 2023
@A5rocks A5rocks added the typing Adding static types to trio's interface label Oct 4, 2023
Copy link
Member

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@A5rocks A5rocks merged commit 3d62ea0 into python-trio:master Oct 5, 2023
27 of 28 checks passed
@A5rocks A5rocks deleted the type-hints-classifier branch October 5, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typing Adding static types to trio's interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants