-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type annotations for windows_pipes and its test #2812
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2812 +/- ##
=======================================
Coverage 99.13% 99.13%
=======================================
Files 115 115
Lines 17230 17230
Branches 3084 3084
=======================================
Hits 17081 17081
Misses 104 104
Partials 45 45
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks simple enough, just one small comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Types on _windows_pipes.py
looks trivially correct. The test seems overcomplicated and gives codecov misses, but otherwise perfectly fine as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicks but overall looks good (I don't really get the = Any
bits)
agh, why is codecov being so dumb. It's incredibly frustrating that you can't trust the warnings displayed in the |
This PR adds type annotations for
_windows_pipes.py
and_tests/test_windows_pipes.py
.