-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export test fixes #2887
Export test fixes #2887
Changes from 8 commits
f70c656
873ac42
4ed1cfa
1397edc
80e130e
c31ffba
bac649e
c74f51b
ca46414
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,13 +67,19 @@ | |
ntohs as ntohs, | ||
) | ||
|
||
# TODO: update python docs to reflect this | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. mostly just this that's a blocker There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hopefully done with python/typeshed#11073 and https://foss.heptapod.net/pypy/pypy/-/issues/4040. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well I made a typeshed PR thinking "oh well the stdlib docs are the spec, so PyPy is deviating from it and should not have the docs update for it" but then now I realize And it looks like these functions just never exist on PyPy. Lol. |
||
if sys.implementation.name == "cpython": | ||
from socket import ( | ||
if_indextoname as if_indextoname, | ||
if_nameindex as if_nameindex, | ||
if_nametoindex as if_nametoindex, | ||
) | ||
|
||
|
||
# not always available so expose only if | ||
if sys.platform != "win32" or not _t.TYPE_CHECKING: | ||
with _suppress(ImportError): | ||
from socket import ( | ||
if_indextoname as if_indextoname, | ||
if_nameindex as if_nameindex, | ||
if_nametoindex as if_nametoindex, | ||
sethostname as sethostname, | ||
) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels weird though, like I don't think codecov should be complaining about this :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, this is the issue where we have double codecov runs on some PRs - and the inline errors are taken from the "incorrect" codecov run, I've seen this a couple times.
That's also the same as #2887 (comment) not getting updated.
I was gonna try and link them .. when I noticed that one set links to https://app.codecov.io/gh/python-trio/trio/commit/c74f51bf891c940d4ec7ed5859e55ab91a2a1809 and the other links to https://github.com/python-trio/trio/pull/2887/checks?check_run_id=19006357499 in the "details" link in the summary. Which is maybe a good hint to what's causing it?
We need some more messing around with codecov 🙃, see also #2689