-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alpine to CI #2933
Add Alpine to CI #2933
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2933 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 116 116
Lines 17506 17506
Branches 3148 3148
=======================================
Hits 17444 17444
Misses 43 43
Partials 19 19
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed the test logs, and IPv6 tests are being skipped
SKIPPED [1] ../.venv/lib/python3.11/site-packages/trio/_tests/test_dtls.py:87: need IPv6
probably not a big deal, but would be nice if it was possible to enable ipv6.
So other than the minor stuff, looks great!
Doesn't look like we can do IPv6. Making the socket works, but binding fails. It seems that this is a docker thing and that we'd need to configure the docker daemon? I found this stackoverflow post but it has no answers: https://stackoverflow.com/questions/75205327/configuring-docker-daemon-for-github-actions Edit: also I removed |
Seems quite doable in theory then, but not worth the effort. |
Ref: #2885