-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit.ci] pre-commit autoupdate #2946
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.1.14 → v0.2.0](astral-sh/ruff-pre-commit@v0.1.14...v0.2.0)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2946 +/- ##
==========================================
+ Coverage 99.44% 99.64% +0.19%
==========================================
Files 117 117
Lines 17564 17564
Branches 3166 3166
==========================================
+ Hits 17467 17502 +35
+ Misses 79 43 -36
- Partials 18 19 +1 |
Pretty good, but I think we might need to make a few minor config changes: https://astral.sh/blog/ruff-v0.2.0 |
Oh that's cool, a few of the |
Getting some kind of wacky pypy 3.10 failures: |
Probably should enable the TRIO rules? Maybe in a separate PR. |
it's specifically pypy 3.10-nightly, so probably time to fix
as mentioned in #2885 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reran one of the pypy-3.10-nightly jobs here: https://github.com/python-trio/trio/actions/runs/7792993619/job/21432501263?pr=2946
It didn't error this time. Probably just a bad nightly version.
updates: