-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spellchecking with crate-ci/typos
#3166
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3166 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 124 124
Lines 18427 18427
Branches 1215 1215
===============================================
Hits 18427 18427
|
``b"xn--caf-dma.com"``. | ||
|
||
""" | ||
``b"xn--caf-dma.com"``.""" # spellchecker:disable-line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xn--caf is both in extend-identifiers in pyproject.toml and has spellchecker:disable-line
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason extend-identifiers does does not work as I intended and continues to try replacing it, so I added spellchecker:disable-line
there to solve the issue. If there would be a way to get extend-identifiers to do ignore that one like I intended, that would be a better solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in that case we should at least remove the non-functioning line in extend-identifiers, unless you wanna report it upstream.
with PARMETER->PARAMETER this needs a newsfragment |
In this pull request, we add https://github.com/crate-ci/typos as a pre-commit spellchecker and fix various typos found with this particular spellchecker.
They claim to have more features than codespell, but I don't really see a reason why we couldn't use both as long as they aren't fighting each other.
I learned about crate-ci/typos quite recently when looking through changes made to the mypy daemon as a part of mypy 1.14.0, so I'm not super familiar with how the configuration works, but I think it's at least mostly working as is. What I've tried to add as known "identifiers" with
-
s in them don't seem to be functioning as I intended however.