Rework test_run_local_simultaneous_runs to be more reliable #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to use a single queue to send messages to and from the threads, which of course is unreliable because the main thread could end up reading back its own message. In particular, on PyPy this happened regularly, and occasionally it meant that the test deadlocked. So this fixed python-triogh-379. This patch also updates the test harness to actually pull errors back from the child threads, so that if the test does fail then we can detect it.
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
=========================================
+ Coverage 99.2% 99.2% +<.01%
=========================================
Files 89 89
Lines 10338 10345 +7
Branches 720 720
=========================================
+ Hits 10256 10263 +7
Misses 61 61
Partials 21 21
Continue to review full report at Codecov.
|
|
This makes a lot of sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to use a single queue to send messages to and from the
threads, which of course is unreliable because the main thread could
end up reading back its own message. In particular, on PyPy this
happened regularly, and occasionally it meant that the test
deadlocked. So this fixed gh-379.
This patch also updates the test harness to actually pull errors back
from the child threads, so that if the test does fail then we can
detect it.