Address code review

python · Sep 25, 2024 · bc751d7 · bc751d7
1 parent 4eab926
commit bc751d7
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 14 deletions.
diff --git a/Python/bytecodes.c b/Python/bytecodes.c
@@ -1647,10 +1647,10 @@ dummy_func(
             value = PyStackRef_FromPyObjectSteal(value_o);
         }
 
-        inst(LOAD_DEREF, ( -- value)) {
+        inst(LOAD_DEREF, ( -- value[1])) {
             PyCellObject *cell = (PyCellObject *)PyStackRef_AsPyObjectBorrow(GETLOCAL(oparg));
-            _PyCell_GetStackRef(cell, &value);
-            if (PyStackRef_IsNull(value)) {
+            _PyCell_GetStackRef(cell, value);
+            if (PyStackRef_IsNull(*value)) {
                 _PyEval_FormatExcUnbound(tstate, _PyFrame_GetCode(frame), oparg);
                 ERROR_IF(true, error);
             }

diff --git a/Python/executor_cases.c.h b/Python/executor_cases.c.h
diff --git a/Python/generated_cases.c.h b/Python/generated_cases.c.h
diff --git a/Python/optimizer_cases.c.h b/Python/optimizer_cases.c.h