Address comments

python · Sep 26, 2024 · f238189 · f238189
1 parent 8ff071f
commit f238189
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/Python/bytecodes.c b/Python/bytecodes.c
@@ -4838,9 +4838,9 @@ dummy_func(
 
         tier2 op(_MAKE_WARM, (--)) {
             current_executor->vm_data.warm = true;
-            if (++tstate->interp->trace_run_counter > JIT_CLEANUP_THRESHOLD) {
+            // It's okay if this ends up going negative.
+            if (--tstate->interp->trace_run_counter == 0) {
                 _Py_set_eval_breaker_bit(tstate, _PY_EVAL_JIT_INVALIDATE_COLD_BIT);
-                tstate->interp->trace_run_counter = 0;
             }
         }
 

diff --git a/Python/ceval_gil.c b/Python/ceval_gil.c
@@ -1292,6 +1292,7 @@ _Py_HandlePending(PyThreadState *tstate)
     if ((breaker & _PY_EVAL_JIT_INVALIDATE_COLD_BIT) != 0) {
         _Py_unset_eval_breaker_bit(tstate, _PY_EVAL_JIT_INVALIDATE_COLD_BIT);
         _Py_Executors_InvalidateCold(tstate->interp);
+        tstate->interp->trace_run_counter = JIT_CLEANUP_THRESHOLD;
     }
 
     /* GIL drop request */

diff --git a/Python/executor_cases.c.h b/Python/executor_cases.c.h