Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_tarfile fails on file modes #107902

Closed
2 tasks done
furkanonder opened this issue Aug 12, 2023 · 1 comment
Closed
2 tasks done

test_tarfile fails on file modes #107902

furkanonder opened this issue Aug 12, 2023 · 1 comment
Assignees
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@furkanonder
Copy link
Contributor

furkanonder commented Aug 12, 2023

Checklist

  • I am confident this is a bug in CPython, not a bug in a third-party project
  • I have searched the CPython issue tracker, and am confident this bug has not been reported before

[ted@rasp4 cpython]$ ./python -m test test_tarfile
0:00:00 load avg: 0.27 Run tests sequentially
0:00:00 load avg: 0.27 [1/1] test_tarfile
test test_tarfile failed -- Traceback (most recent call last):
  File "/home/ted/cpython/Lib/test/test_tarfile.py", line 3679, in test_modes
    self.expect_file('all_bits', mode='?rwsrwsrwt')
  File "/home/ted/cpython/Lib/test/test_tarfile.py", line 3429, in expect_file
    self.assertEqual(got, mode)
AssertionError: '?rwsrwxrwt' != '?rwsrwsrwt'
- ?rwsrwxrwt
?       ^
+ ?rwsrwsrwt
?       ^

Your environment

  • CPython versions tested on: Python 3.13.0a0
  • Operating system and architecture: Manjaro ARM Linux aarch64 | Raspberry Pi 4 Model B Rev 1.5
  • Configuration of CPython: ./configure --with-pydebug

Linked PRs

@furkanonder furkanonder added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels Aug 12, 2023
encukou added a commit to encukou/cpython that referenced this issue Aug 23, 2023
@encukou
Copy link
Member

encukou commented Sep 4, 2023

Thanks for the report!
The test fix was merged in main. Let me know if you need a backport -- I won't make one by default since this is only a test issue for a platform without buildbots. I assume you can patch/skip the test on your build.

@encukou encukou closed this as completed Sep 4, 2023
encukou added a commit to encukou/cpython that referenced this issue Oct 10, 2024
encukou added a commit to encukou/cpython that referenced this issue Oct 16, 2024
pablogsal pushed a commit that referenced this issue Oct 22, 2024
…ystems that don't support them (GH-108368) (GH-109697) (#125255)

* gh-107902: Don't test setting suid/sgid on systems that don't support them (GH-108368)

* gh-108948: Skip test_tarfile.test_modes() on EFTYPE error (#109697)

On FreeBSD, regular users cannot set the sticky bit. Skip the test if
chmod() fails with EFTYPE error.

---------

Co-authored-by: Victor Stinner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 22, 2024
…/sticky on systems that don't support them (pythonGH-108368) (pythonGH-109697) (pythonGH-125255)

* pythongh-107902: Don't test setting suid/sgid on systems that don't support them (pythonGH-108368)

* pythongh-108948: Skip test_tarfile.test_modes() on EFTYPE error (pythonGH-109697)

On FreeBSD, regular users cannot set the sticky bit. Skip the test if
chmod() fails with EFTYPE error.

---------

(cherry picked from commit 6bbaab8)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants