[3.9] [3.10] gh-107902: gh-108948: Don't test setting suid/sgid/sticky on systems that don't support them (GH-108368) (GH-109697) (GH-125255) #125835
+39
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/sticky on systems that don't support them (pythonGH-108368) (pythonGH-109697) (pythonGH-125255) * pythongh-107902: Don't test setting suid/sgid on systems that don't support them (pythonGH-108368) * pythongh-108948: Skip test_tarfile.test_modes() on EFTYPE error (pythonGH-109697) On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error. --------- (cherry picked from commit 6bbaab8) Co-authored-by: Petr Viktorin <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
2 tasks
|
Thanks @miss-islington, but let's use #125576 instead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_tarfile fails on file modes #107902: Don't test setting suid/sgid on systems that don't support them (gh-107902: Don't test setting suid/sgid on systems that don't support them #108368)
tarfile doesn't set file modes correctly on FreeBSD: test_tarfile.test_modes() fails on FreeBSD #108948: Skip test_tarfile.test_modes() on EFTYPE error (gh-108948: Skip test_tarfile.test_modes() on EFTYPE error #109697)
On FreeBSD, regular users cannot set the sticky bit. Skip the test if
chmod() fails with EFTYPE error.
(cherry picked from commit 6bbaab8)
Co-authored-by: Petr Viktorin [email protected]
Co-authored-by: Victor Stinner [email protected]