Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT workflow is executed on unrelated changes in my local fork #114788

Closed
sobolevn opened this issue Jan 31, 2024 · 0 comments
Closed

JIT workflow is executed on unrelated changes in my local fork #114788

sobolevn opened this issue Jan 31, 2024 · 0 comments
Assignees
@sobolevn
Labels
topic-JIT type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Jan 31, 2024 •
edited by bedevere-app bot
Loading

Bug report

There are several potential problems in this:
Снимок экрана 2024-01-31 в 11 26 45

  1. We have a failing JIT test job, CC @brandtbucher, link: https://github.com/sobolevn/cpython/actions/runs/7722621656/job/21051101804 Note, that it does not fail in 100% of cases, only sometimes
  2. It is executed in my fork, while no other tests are
  3. It is executed on a doc-only change, while other tests ignore such changes

I will send a PR to fix 2. and 3.

Linked PRs
@sobolevn sobolevn added the type-bug An unexpected behavior, bug, or error label Jan 31, 2024
@sobolevn sobolevn self-assigned this Jan 31, 2024
sobolevn added a commit to sobolevn/cpython that referenced this issue Jan 31, 2024
@sobolevn
pythongh-114788: Do not run JIT workflow on unrelated changes
73f0bb5
@bedevere-app bedevere-app bot mentioned this issue Jan 31, 2024
Merged
@sobolevn sobolevn mentioned this issue Jan 31, 2024
Closed
hugovk added a commit that referenced this issue Jan 31, 2024
@sobolevn @hugovk
gh-114788: Do not run JIT workflow on unrelated changes (#114789)
b25b746 
Co-authored-by: Hugo van Kemenade <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@sobolevn @hugovk @aisk
pythongh-114788: Do not run JIT workflow on unrelated changes (python…
72d4e56 
…#114789)

Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
topic-JIT type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolevn @brandtbucher