-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-114788: Do not run JIT workflow on unrelated changes #114789
Conversation
Co-authored-by: Hugo van Kemenade <[email protected]>
Let's try it! Since this way is much easier. |
After new changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait a minute, changing bytecode also means the JIT stencils generated will change. So I think we should also detect for changes in Python/bytecodes.c
.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Just so I understand, the |
Yes :) |
…#114789) Co-authored-by: Hugo van Kemenade <[email protected]>
First change is about
concurrency:
. We simply cancel previous runs not to waste resources.Second, docs say that
paths
should be like this:Plus, I also included
**/*jit*.*
to match any files withjit
prefix or suffix in its name.First run: changed
jit.yml
JIT workflow is there ✅
Second run: added a PR to this branch in my fork with unrelated changes.
No JIT workflow ✅