Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-60712: Include the "object" type in the lists of documented types #103036
base: main
Are you sure you want to change the base?
gh-60712: Include the "object" type in the lists of documented types #103036
Changes from 28 commits
2c09057
9a71e36
d327409
73698a5
1064065
ce4d192
aca2c04
f6c12d8
b1ab4a2
d709946
105f331
119e29b
d8c1995
7762a08
7ffed7c
5ad51b9
71a2d43
2d9f0a0
10adcee
f9961eb
ab5ef40
6681f67
7d68154
3f41130
026e514
7181046
69b710a
55f8c6a
b199746
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we had a doc bug years ago where we came up with a convention to differentiate
object.__str__
(actual method that exists in theobject
class),anyclass.__bases__
(method that exists on all class; explaining the data model) andsomeclass.__str__
(method you can define in your class to implement a protocol)I guess we didn’t…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Hm… on the line before, we see a general term used (with a link to glossary) and a concrete example in parens (list and tuple links), then we have the general/glossary term mappings and should keep the specific type dict in parens to keep the intent of the text. On the other hand, if the glossary term for dictionaries is a better explanation than the dict type/function doc, and more specific than the term for mappings, the changed link could be an improvement.