Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-102304: doc: Add links to Stable ABI and Limited C API #105345

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 6, 2023

  • Add "limited-c-api" and "stable-api" references.

  • Rename "stable-abi-list" reference to "limited-api-list".

  • Makefile: Document files regenerated by "make regen-limited-abi"

  • Remove first empty line in generated files:

    • Lib/test/test_stable_abi_ctypes.py
    • PC/python3dll.c

📚 Documentation preview 📚: https://cpython-previews--105345.org.readthedocs.build/

* Add "limited-c-api" and "stable-api" references.
* Rename "stable-abi-list" reference to "limited-api-list".
* Makefile: Document files regenerated by "make regen-limited-abi"
* Remove first empty line in generated files:

  - Lib/test/test_stable_abi_ctypes.py
  - PC/python3dll.c
@vstinner vstinner requested a review from a team as a code owner June 6, 2023 08:14
@vstinner vstinner enabled auto-merge (squash) June 6, 2023 08:33
@vstinner vstinner merged commit bae415a into python:main Jun 6, 2023
@vstinner vstinner deleted the limited-c-api branch June 6, 2023 08:40
@vstinner vstinner added the needs backport to 3.12 bug and security fixes label Jun 6, 2023
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105347 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 6, 2023
…onGH-105345)

* Add "limited-c-api" and "stable-api" references.
* Rename "stable-abi-list" reference to "limited-api-list".
* Makefile: Document files regenerated by "make regen-limited-abi"
* Remove first empty line in generated files:

  - Lib/test/test_stable_abi_ctypes.py
  - PC/python3dll.c
(cherry picked from commit bae415a)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 6, 2023
@encukou
Copy link
Member

encukou commented Jun 6, 2023

A few nitpicks, but this looks great overall! Thank you!

@vstinner
Copy link
Member Author

vstinner commented Jun 6, 2023

A few nitpicks, but this looks great overall! Thank you!

I created PR #105351 follow-up. I wanted to quickly merged this PR to unblock PR #104763 which relies on it.

@vstinner
Copy link
Member Author

vstinner commented Jun 6, 2023

Thanks @encukou for the review after merge ;-)

vstinner added a commit to vstinner/cpython that referenced this pull request Jun 6, 2023
…on#105345)

* Add "limited-c-api" and "stable-api" references.
* Rename "stable-abi-list" reference to "limited-api-list".
* Makefile: Document files regenerated by "make regen-limited-abi"
* Remove first empty line in generated files:

  - Lib/test/test_stable_abi_ctypes.py
  - PC/python3dll.c

(cherry picked from commit bae415a)
@bedevere-bot
Copy link

GH-105371 is a backport of this pull request to the 3.12 branch.

vstinner added a commit that referenced this pull request Jun 6, 2023
…5345) (#105371)

* gh-102304: doc: Add links to Stable ABI and Limited C API (#105345)

* Add "limited-c-api" and "stable-api" references.
* Rename "stable-abi-list" reference to "limited-api-list".
* Makefile: Document files regenerated by "make regen-limited-abi"
* Remove first empty line in generated files:

  - Lib/test/test_stable_abi_ctypes.py
  - PC/python3dll.c

(cherry picked from commit bae415a)

* gh-102304: Fix up Simple ABI doc (GH-105351)

(cherry picked from commit 0202aa0)
@AA-Turner AA-Turner added the needs backport to 3.11 only security fixes label Sep 26, 2023
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker bae415ad02c79cf3a2eec4aa6969221a12e6716f 3.11

@AA-Turner
Copy link
Member

Looking to backport this to 3.11 for python/devguide#1167.

A

AA-Turner pushed a commit to AA-Turner/cpython that referenced this pull request Sep 26, 2023
python#105345) (python#105371)

* pythongh-102304: doc: Add links to Stable ABI and Limited C API (python#105345)

* Add "limited-c-api" and "stable-api" references.
* Rename "stable-abi-list" reference to "limited-api-list".
* Makefile: Document files regenerated by "make regen-limited-abi"
* Remove first empty line in generated files:

  - Lib/test/test_stable_abi_ctypes.py
  - PC/python3dll.c

(cherry picked from commit bae415a)

* pythongh-102304: Fix up Simple ABI doc (pythonGH-105351)

(cherry picked from commit 0202aa0)
(cherry picked from commit 82ab13c)
AA-Turner pushed a commit to AA-Turner/cpython that referenced this pull request Sep 26, 2023
python#105345) (python#105371)

* pythongh-102304: doc: Add links to Stable ABI and Limited C API (python#105345)

* Add "limited-c-api" and "stable-api" references.
* Rename "stable-abi-list" reference to "limited-api-list".
* Makefile: Document files regenerated by "make regen-limited-abi"
* Remove first empty line in generated files:

  - Lib/test/test_stable_abi_ctypes.py
  - PC/python3dll.c

(cherry picked from commit bae415a)

* pythongh-102304: Fix up Simple ABI doc (pythonGH-105351)

(cherry picked from commit 0202aa0)
(cherry picked from commit 82ab13c)
erlend-aasland pushed a commit that referenced this pull request Sep 29, 2023
…105345) (#105371) (#109901)

* Add "limited-c-api" and "stable-api" targets
* Rename the "stable-abi-list" target to "limited-api-list"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants