Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-96165: Clarify passing ":memory:" in sqlite3.connect(). #106451

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

felixxm
Copy link
Contributor

@felixxm felixxm commented Jul 5, 2023

":memory:" is only mentioned in this document, so I think it's enough to clarify it a bit here.


📚 Documentation preview 📚: https://cpython-previews--106451.org.readthedocs.build/

@felixxm
Copy link
Contributor Author

felixxm commented Jul 5, 2023

@erlend-aasland Thanks for checking 👍 I will try to prepare more small PRs for gh-96165 to follow the principles outlined in the ​Diátaxis framework.

@erlend-aasland erlend-aasland merged commit f520804 into python:main Jul 11, 2023
@miss-islington
Copy link
Contributor

Thanks @felixxm for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 11, 2023
@bedevere-bot
Copy link

GH-106647 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 11, 2023
@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 11, 2023
@bedevere-bot
Copy link

GH-106648 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 11, 2023
erlend-aasland pushed a commit that referenced this pull request Jul 11, 2023
@felixxm
Copy link
Contributor Author

felixxm commented Jul 11, 2023

@erlend-aasland Thanks 🎉

erlend-aasland pushed a commit that referenced this pull request Jul 11, 2023
@felixxm felixxm deleted the memory-sqlite-96165 branch July 11, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants