Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106847: Add -X warn_default_encoding in sys.flags Doc #106854

Merged
merged 5 commits into from
Jul 21, 2023
Merged

gh-106847: Add -X warn_default_encoding in sys.flags Doc #106854

merged 5 commits into from
Jul 21, 2023

Conversation

qqwqqw689
Copy link
Contributor

@qqwqqw689 qqwqqw689 commented Jul 18, 2023

The table of sys.flags doesn't have warn_default_encoding attribute.
So I add it.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jul 18, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 18, 2023
@sobolevn sobolevn changed the title Add -X warn_default_encoding in sys.falgs Doc gh-106847: Add -X warn_default_encoding in sys.falgs Doc Jul 18, 2023
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Doc/library/sys.rst Outdated Show resolved Hide resolved
@qqwqqw689 qqwqqw689 requested a review from sobolevn July 18, 2023 23:33
@sobolevn sobolevn requested a review from FFY00 July 19, 2023 06:28
@qqwqqw689 qqwqqw689 changed the title gh-106847: Add -X warn_default_encoding in sys.falgs Doc gh-106847: Add -X warn_default_encoding in sys.flags Doc Jul 19, 2023
@methane methane self-requested a review July 20, 2023 12:11
@kumaraditya303 kumaraditya303 added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jul 21, 2023
@kumaraditya303 kumaraditya303 merged commit fd84ac0 into python:main Jul 21, 2023
19 checks passed
@miss-islington
Copy link
Contributor

Thanks @qqwqqw689 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @qqwqqw689 and @kumaraditya303, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker fd84ac0ee0a8d5e34e0a106eed7e50539b61c5f8 3.12

@bedevere-bot
Copy link

GH-106958 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2023
…nGH-106854)

(cherry picked from commit fd84ac0)

Co-authored-by: qqwqqw689 <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
methane pushed a commit that referenced this pull request Jul 22, 2023
gh-106847: Add -X warn_default_encoding in sys.flags Doc (GH-106854)
(cherry picked from commit fd84ac0)

Co-authored-by: qqwqqw689 <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
@methane methane added needs backport to 3.12 bug and security fixes and removed needs backport to 3.12 bug and security fixes labels Jul 22, 2023
@miss-islington
Copy link
Contributor

Thanks @qqwqqw689 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2023
…nGH-106854)

(cherry picked from commit fd84ac0)

Co-authored-by: qqwqqw689 <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot
Copy link

GH-107054 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 22, 2023
methane pushed a commit that referenced this pull request Jul 22, 2023
gh-106847: Add -X warn_default_encoding in sys.flags Doc (GH-106854)
(cherry picked from commit fd84ac0)

Co-authored-by: qqwqqw689 <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants