-
-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-106581: Split CALL_PY_EXACT_ARGS
into uops
#107760
Merged
Merged
Commits on Aug 9, 2023
-
Split
CALL_PY_EXACT_ARGS
into uopsThis is only the first step for doing `CALL` in Tier 2. The next step involves tracing into the called code object. After that we'll have to do the remaining `CALL` specialization. Finally we'll have to tweak various things like `KW_NAMES`, and possibly move the `NULL` (for method calls) *above* the callable. But those are things for future PRs. Note: this moves setting `frame->return_offset` directly in front of `DISPATCH_INLINED()`, to make it easier to move it into `_PUSH_FRAME`.
Configuration menu - View commit details
-
Copy full SHA for 56133bb - Browse repository at this point
Copy the full SHA 56133bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 907ff95 - Browse repository at this point
Copy the full SHA 907ff95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c6be6d - Browse repository at this point
Copy the full SHA 2c6be6dView commit details
Commits on Aug 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6d78ff2 - Browse repository at this point
Copy the full SHA 6d78ff2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d8e66c - Browse repository at this point
Copy the full SHA 0d8e66cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b75f30e - Browse repository at this point
Copy the full SHA b75f30eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61c2822 - Browse repository at this point
Copy the full SHA 61c2822View commit details -
Configuration menu - View commit details
-
Copy full SHA for f73ea90 - Browse repository at this point
Copy the full SHA f73ea90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12910fc - Browse repository at this point
Copy the full SHA 12910fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fafa2c - Browse repository at this point
Copy the full SHA 2fafa2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2717b07 - Browse repository at this point
Copy the full SHA 2717b07View commit details -
Configuration menu - View commit details
-
Copy full SHA for e487908 - Browse repository at this point
Copy the full SHA e487908View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d549af - Browse repository at this point
Copy the full SHA 1d549afView commit details -
Configuration menu - View commit details
-
Copy full SHA for f40fb1f - Browse repository at this point
Copy the full SHA f40fb1fView commit details
Commits on Aug 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4f6f8f8 - Browse repository at this point
Copy the full SHA 4f6f8f8View commit details -
Make less of a special case of _PUSH_FRAME
Instead, the special case is an opcode using SAVE_FRAME_STATE(). Introducing #if TIER_ONE and #if TIER_TWO so we can implement _PUSH_FRAME differently for both tiers.
Configuration menu - View commit details
-
Copy full SHA for 6facc8d - Browse repository at this point
Copy the full SHA 6facc8dView commit details -
Stop special-casing _PUSH_FRAME altogether
Instead, we special-case SAVE_IP: - Its Tier 2 expansion sets oparg to the instruction offset - In Tier 1 it is a no-op (and skipped if present in a macro)
Configuration menu - View commit details
-
Copy full SHA for 94630d4 - Browse repository at this point
Copy the full SHA 94630d4View commit details
Commits on Aug 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cf8e2c0 - Browse repository at this point
Copy the full SHA cf8e2c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e62876 - Browse repository at this point
Copy the full SHA 1e62876View commit details
Commits on Aug 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 05af848 - Browse repository at this point
Copy the full SHA 05af848View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.