gh-110631: Fix reST indentation in Doc/library
#110685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezio-melotti
added
docs
ezio-melotti
requested review from
ethanfurman,
rhettinger,
berkerpeksag,
erlend-aasland,
a team and
vsajip
as code owners
ezio-melotti
commented
Oct 11, 2023
Comment on lines
-1001
to
1002
| * width: width | ||
| width: width | ||
| The width of the column in pixels. |
There was a problem hiding this comment.
This and the next few chunks created a weird definition list with bullets. I removed the bullets to create a regular definition list. The markup of the dts could be improved by adding some ``...`` too, to make them stand out more.
|
Sphinx indents should be three, not two spaces, no? |
I just time-machined an answer for you here: #110635 (comment) |
erlend-aasland
changed the title
Doc/library dir.Doc/library dir
erlend-aasland
approved these changes
Oct 11, 2023
ezio-melotti
changed the title
Doc/library dirDoc/library
hugovk
approved these changes
Oct 11, 2023
|
Thanks @ezio-melotti for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @ezio-melotti, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 11, 2023
Fix wrong indentation in the Doc/library dir. (cherry picked from commit bb7923f) Co-authored-by: Ezio Melotti <[email protected]>
|
GH-110736 is a backport of this pull request to the 3.12 branch. |
ezio-melotti
added a commit
to ezio-melotti/cpython
that referenced
this pull request
Oct 11, 2023
…GH-110685) Fix wrong indentation in the Doc/library dir.. (cherry picked from commit bb7923f) Co-authored-by: Ezio Melotti <[email protected]>
|
GH-110737 is a backport of this pull request to the 3.11 branch. |
ezio-melotti
added a commit
that referenced
this pull request
Oct 11, 2023
…110736) gh-110631: Fix reST indentation in `Doc/library` (GH-110685) Fix wrong indentation in the Doc/library dir. (cherry picked from commit bb7923f) Co-authored-by: Ezio Melotti <[email protected]>
ezio-melotti
added a commit
that referenced
this pull request
Oct 11, 2023
…110737) * [3.11] gh-110631: Fix reST indentation in `Doc/library` (GH-110685) Fix wrong indentation in the Doc/library dir.. (cherry picked from commit bb7923f) Co-authored-by: Ezio Melotti <[email protected]> * Fix merge glitch.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Fix wrong indentation in the Doc/library dir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes indentation errors that resulted in spurious
blockquotes and definition lists in theDoc/librarydir.📚 Documentation preview 📚: https://cpython-previews--110685.org.readthedocs.build/