Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] gh-114021: Pin various sphinxcontrib extensions to older versions (GH-114022) #114039

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Jan 13, 2024

… older versions (pythonGH-114022).

(cherry picked from commit 94b1d1f)

Co-authored-by: Ronald Oussoren <[email protected]>
babel<3
colorama<0.5
imagesize<1.5
Jinja2<3.2
Copy link
Contributor

@m-aciek m-aciek Jan 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Jinja2<3.2

this constraint is superfluous; there's jinja2==3.0.3 in requirements.txt

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a backport, minimal changes are preferable.

@m-aciek
Copy link
Contributor

m-aciek commented Jan 13, 2024

We are introducing constraints.txt, I am wondering if we shouldn't convert current pins in requirements.txt of transitive dependencies to constraints.

# Docutils version is pinned to a version compatible with Sphinx
# version <3.5.4. It can be removed after bumping Sphinx version to at
# least 3.5.4.
docutils==0.17.1
# Jinja version is pinned to a version compatible with Sphinx version <4.5.
jinja2==3.0.3
# Alabaster version is pinned to a version compatible with Sphinx version 2.4.4.
alabaster==0.7.13

into

# docutils 1.18 is incompatible with Sphinx <3.5.4
docutils<1.18
# jinja2 3.1.0 is incompatible with Sphinx <4.5
jinja2<3.1.0
# alabaster 0.7.14 is incompatible with Sphinx 2.4.4
alabaster<0.7.14

in constraints.txt for consistency.

@AA-Turner
Copy link
Member Author

This is a backport, minimal changes are preferable.

@ambv ambv merged commit 2613df8 into python:3.9 Jan 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants