[3.12] gh-46968: Fix invalid reference to Sound eXchange (SoX) 12.17.7 license #115094
Conversation
ambv
changed the title
ambv
added
skip news
needs backport to 3.10
|
The generated files failure is a SPDX failure due to #114971. I'll fix this separately. |
|
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
…12.17.7 license (pythonGH-115094) Fix invalid reference to Sound eXchange (SoX) 12.17.7 license (cherry picked from commit b391199) Co-authored-by: Łukasz Langa <[email protected]>
|
Sorry, @ambv, I could not cleanly backport this to |
|
GH-115095 is a backport of this pull request to the 3.11 branch. |
… license (python#115094) (cherry picked from commit b391199)
… (SoX) 12.17.7 license (pythonGH-115094) Fix invalid reference to Sound eXchange (SoX) 12.17.7 license (cherry picked from commit b391199) Co-authored-by: Łukasz Langa <[email protected]>
|
GH-115096 is the backport of this pull request to the 3.10 branch. |
|
GH-115095 is a backport of this pull request to the 3.11 branch. |
|
GH-115096 is a backport of this pull request to the 3.10 branch. |
|
That's what I said! |
…7 license (GH-115094) (GH-115095) (cherry picked from commit b391199) Co-authored-by: Łukasz Langa <[email protected]>
…7 license (GH-115094) (GH-115096) (cherry picked from commit b391199) Co-authored-by: Łukasz Langa <[email protected]>
|
@ambv I'm curious: why not making it a After merging this contribution, the SOX license text is now basically indented text. Since it is not literal text, it is extracted for translation. As such, might be translation when IMHO it should not. |
The previously referenced license used wording that was incompatible with the overarching Python license:
However, the previously used license text was used in error due to difficulties in finding the referred source files so long after they were incorporated into Python.
This change uses the Sun Microsystems, Inc. license from the version of SoX parts of which are used in Python. This license is fully compatible with the PSF License.
📚 Documentation preview 📚: https://cpython-previews--115094.org.readthedocs.build/