New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.10] gh-116333: Relax error string text expectations in SSL-related tests (GH-116334) #117229

Closed

WillChilds-Klein wants to merge 2 commits into python:3.10 from WillChilds-Klein:3.10-relax-ssl-err-strs

Commits on Mar 29, 2024

pythongh-116333 : Relax error string text expectations in SSL-related …

…tests (pythonGH-116334)

As suggested [here][1], this change relaxes the OpenSSL error string
text expectations in a number of tests. This was specifically done in
support of more easily building CPython [AWS-LC][2], but because AWS-LC
is a fork of [BoringSSL][3], it should increase compatibility with that
library as well.

In addition to the error string relaxations, we also add some guards
around the `tls-unique` channel binding being used with TLSv1.3, as that
feature (described in [RFC 6929][4]) is [not defined][5] for TLSv1.3.

[1]: https://discuss.python.org/t/support-building-ssl-and-hashlib-modules-against-aws-lc/44505/4
[2]: https://github.com/aws/aws-lc
[3]: https://github.com/google/boringssl
[4]: https://datatracker.ietf.org/doc/html/rfc5929#section-3
[5]: https://datatracker.ietf.org/doc/html/rfc8446#appendix-C.5

WillChilds-Klein committed Mar 29, 2024

Fix usage of assertRegex in test_ssl.py

WillChilds-Klein committed Mar 29, 2024
Configuration menu
View commit details

Copy full SHA for faf9e7e

Browse repository at this point
Copy the full SHA

faf9e7e View commit details

Browse the repository at this point in the history