Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-117941: Fix argparse issue-Changed call method of BooleanOptionalAction class in argparse.py #117941 #118103

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-117941: Fix argparse issue-Changed call method of BooleanOptionalAction class in argparse.py #117941 #118103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b705c6e
gh-117941: Fix argparse issue-BooleanOptionalAction #117941
jjpapa36912 Apr 19, 2024
88b8228
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Lib/argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,10 @@ def __init__(self,

def __call__(self, parser, namespace, values, option_string=None):
if option_string in self.option_strings:
setattr(namespace, self.dest, not option_string.startswith('--no-'))
if not self.dest.startswith('no'):
setattr(namespace, self.dest, not option_string.startswith('--no-'))
else:
setattr(namespace, self.dest, option_string.count('no') == self.dest.count('no'))

def format_usage(self):
return ' | '.join(self.option_strings)
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/macOS/2024-04-19-13-35-28.gh-issue-117941.s9-8rd.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
write!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the devguide on how to write a NEWS entry.

Loading