gh-118413: Fix test_release_task_refs on free-threaded build #118494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `time.sleep()` call should happen before the GC to give the worker threads time to clean-up their remaining references to objs. Additionally, use `support.gc_collect()` instead of `gc.collect()` just in case the extra GC calls matter.
|
I'm reasonably confident about this fix now. I was able to reliably trigger the test failure quickly by running it in a loop with multiple tests runners on the same CPU. I'm now able to run that loop for a long time without failures. |
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
…ython#118494) The `time.sleep()` call should happen before the GC to give the worker threads time to clean-up their remaining references to objs. Additionally, use `support.gc_collect()` instead of `gc.collect()` just in case the extra GC calls matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
time.sleep()call should happen before the GC to give the worker threads time to clean-up their remaining references to objs. Additionally, usesupport.gc_collect()instead ofgc.collect()just in case the extra GC calls matter.WithThreadsTestPool.test_release_task_refs: flaky test or possible free-threading bug #118413