gh-121160: Note that readline libraries using different history formats. #121327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… formats. This is not something we can do too much about, without help from the underlying libraries.
|
@Yhg1s, you're the readline expert. Does this look good? |
|
I'll merge next week. |
|
Eehh, "expert"... But yeah, I think this is the only thing we can do here. |
Yhg1s
approved these changes
Jul 19, 2024
|
Thanks! Expert just means you've signed up for notifications about tricky or controversial changes :) |
encukou
added
needs backport to 3.12
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @encukou, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 19, 2024
… formats. (pythonGH-121327) This is not something we can do too much about, without help from the underlying libraries. (cherry picked from commit 709db44) Co-authored-by: Petr Viktorin <[email protected]>
|
GH-122030 is a backport of this pull request to the 3.13 branch. |
|
GH-122031 is a backport of this pull request to the 3.12 branch. |
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Jul 19, 2024
…history formats. (pythonGH-121327) This is not something we can do too much about, without help from the underlying libraries. (cherry picked from commit 709db44) Co-authored-by: Petr Viktorin <[email protected]>
encukou
added a commit
that referenced
this pull request
Jul 19, 2024
…y formats. (GH-121327) (GH-122030) This is not something we can do too much about, without help from the underlying libraries. (cherry picked from commit 709db44) Co-authored-by: Petr Viktorin <[email protected]>
encukou
added a commit
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not something we can do too much about, without help from the underlying libraries.
The file formats seem to be treated as implementation details, hidden behind API calls.
readline.set_history_lengthcorrupts history files when used in a libedit build #121160📚 Documentation preview 📚: https://cpython-previews--121327.org.readthedocs.build/