Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] gh-123270: Replaced SanitizedNames with a more surgical fix. (GH-123354) #123432

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Aug 28, 2024

Applies changes from zipp 3.20.1 and jaraco/zipp#124 (cherry picked from commit 2231286) (cherry picked from commit 17b77bb)

Supersedes #123161.

…gical fix. (pythonGH-123354)

Applies changes from zipp 3.20.1 and jaraco/zippGH-124
(cherry picked from commit 2231286)
(cherry picked from commit 17b77bb)

Co-authored-by: Jason R. Coombs <[email protected]>
@jaraco
Copy link
Member Author

jaraco commented Aug 28, 2024

Although the build fails, we can be confident that the functionality is good, because these changes were adopted by zipp 3.20.1 and tested against Python 3.9 on macOS.

@jaraco
Copy link
Member Author

jaraco commented Sep 2, 2024

I don't understand why the tests are passing on Windows when two of the the 3.10 tests in #123426 were failing on Windows.

@jaraco
Copy link
Member Author

jaraco commented Sep 2, 2024

Aha! It's because in Python 3.9, zipfile.Path.name still uses posixpath.

@ambv ambv merged commit 9620552 into python:3.9 Sep 4, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants