[3.10] gh-123693: Use platform-agnostic semantics when processing zipfile.Path.name. #123694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgical fix. (pythonGH-123354) Applies changes from zipp 3.20.1 and jaraco/zippGH-124 (cherry picked from commit 2231286) (cherry picked from commit 17b77bb) Co-authored-by: Jason R. Coombs <[email protected]>
This reverts commit d1eca1e.
…ePosixPath for platform-agnostic behavior. Aligns with Python 3.9 and 3.11 behavor and fixes failing tests.
|
I chose not to replace the patch with exactly the patch that is found in Python 3.11 and later, because that changed other semantics. I'm expecting this selective change to allow the tests to pass and address the missed expectation. |
|
Until this PR is rebased onto main after merging the dependent PR, here is the diff for this PR. |
|
You can rebase now. |
|
I've merged and the diff is now good. The macOS failure is unrelated. I did not rebase, as the squash merge will handle that. Please merge whenever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on, merge after GH-123426.
Closes #123693.