[3.12] [CVE-2023-27043] gh-102988: Reject malformed addresses in email.parseaddr() (GH-111116) #123766
+361
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n email.parseaddr() (pythonGH-111116) Detect email address parsing errors and return empty tuple to indicate the parsing error (old API). Add an optional 'strict' parameter to getaddresses() and parseaddr() functions. Patch by Thomas Dwyer. Co-Authored-By: Thomas Dwyer <[email protected]> (cherry picked from commit 4a153a1)
bedevere-app
bot
added
type-bug
miketheman
added a commit
to miketheman/warehouse
that referenced
this pull request
Sep 12, 2024
Now that Python validates the addresses more strictly, we won't hit the condition any longer. If we wish to preserve this condition, we could also pass `strict=False` to `getaddresses()`, but that seems to be counter to our desire of having a valid email address. Refs: python/cpython#123766 Signed-off-by: Mike Fiedler <[email protected]>
ewdurbin
pushed a commit
to pypi/warehouse
that referenced
this pull request
Sep 13, 2024
* chore: update Python 3.12.6 Refs: https://www.python.org/downloads/release/python-3126/ Signed-off-by: Mike Fiedler <[email protected]> * chore: remove unreachable condition Now that Python validates the addresses more strictly, we won't hit the condition any longer. If we wish to preserve this condition, we could also pass `strict=False` to `getaddresses()`, but that seems to be counter to our desire of having a valid email address. Refs: python/cpython#123766 Signed-off-by: Mike Fiedler <[email protected]> * test: refactor test case to parametrize Extract test cases from inline to make it clearer which permutations are being tested. Signed-off-by: Mike Fiedler <[email protected]> --------- Signed-off-by: Mike Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect email address parsing errors and return empty tuple to indicate the parsing error (old API). Add an optional 'strict' parameter to getaddresses() and parseaddr() functions. Patch by Thomas Dwyer.
Co-Authored-By: Thomas Dwyer [email protected]
(cherry picked from commit 4a153a1)
📚 Documentation preview 📚: https://cpython-previews--123766.org.readthedocs.build/