Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-123978: Remove broken time.thread_time() on NetBSD #124116

Merged
merged 6 commits into from
Sep 24, 2024
Merged

gh-123978: Remove broken time.thread_time() on NetBSD #124116

merged 6 commits into from
Sep 24, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 16, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 16, 2024
Open
@vstinner vstinner mentioned this pull request Sep 16, 2024
Merged
@furkanonder furkanonder added type-bug An unexpected behavior, bug, or error needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Sep 17, 2024
vstinner
vstinner approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner removed needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Sep 18, 2024
@vstinner
Copy link
Member

I'm not sure about backporting this change: it can be surprising that a function disappears in a 3.x.y bugfix release. I prefer to keep the broken function in stable versions. (And sadly it's too late for 3.13.0 final.)

@furkanonder
Copy link
Contributor

LGTM

@serhiy-storchaka
Copy link
Member Author

This function is optional. If the underlying OS function is broken, we either try to implement Python API using other functions or do not provide it at all. This is not the first time we have deal with broken OS API.

@vstinner
Copy link
Member

@serhiy-storchaka:

This function is optional. If the underlying OS function is broken, we either try to implement Python API using other functions or do not provide it at all. This is not the first time we have deal with broken OS API.

If this is a rationale for backport, well, it's up to you to decide to backport this change or not.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) September 24, 2024 07:57
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Sep 24, 2024
@serhiy-storchaka serhiy-storchaka merged commit e670a11 into python:main Sep 24, 2024
39 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 24, 2024
@serhiy-storchaka @miss-islington
pythongh-123978: Remove broken time.thread_time() on NetBSD (pythonGH…
17b4b0f 
…-124116)

(cherry picked from commit e670a11)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e670a113b5e1fcc3ce3bb9b5b4b1f126264ae21b 3.12

@bedevere-app
Copy link

bedevere-app bot commented Sep 24, 2024

GH-124425 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 24, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Sep 24, 2024
@serhiy-storchaka
[3.12] pythongh-123978: Remove broken time.thread_time() on NetBSD (p…
b736ab6 
…ythonGH-124116)

(cherry picked from commit e670a11)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 24, 2024

GH-124427 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 24, 2024
gpshead pushed a commit that referenced this pull request Oct 2, 2024
@serhiy-storchaka
[3.12] gh-123978: Remove broken time.thread_time() on NetBSD (GH-124116…
829cdf0 
…) (GH-124427)

(cherry picked from commit e670a11)
@serhiy-storchaka serhiy-storchaka deleted the remove-thread_time-on-netbsd branch October 3, 2024 07:38
serhiy-storchaka added a commit that referenced this pull request Oct 23, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-123978: Remove broken time.thread_time() on NetBSD (GH-124116…
77d7998 
…) (GH-124425)

(cherry picked from commit e670a11)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@furkanonder furkanonder furkanonder approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees

@serhiy-storchaka serhiy-storchaka

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiy-storchaka @vstinner @furkanonder