gh-124176: create_autospec must not change how dataclass defaults are mocked
#124724
+35
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ults are mocked
sobolevn
added
skip news
needs backport to 3.12
cjw296
reviewed
Sep 30, 2024
|
I agree with the backport labels, since we want to backport the test case, even if the functional change doesn't apply cleanly. |
ncoghlan
reviewed
Oct 7, 2024
Co-authored-by: Alyssa Coghlan <[email protected]>
|
@ncoghlan thanks a lot for the helpful suggestions! I applied all of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #124176 (comment)
@ncoghlan found that my change introduced a behavior change (or even a regression) to dataclasses with defaults.
Before my change
create_autospecwould use the default's type for_spec_class.After my change it would use the annotation's type.
Which is not always correct. For example,
int | strwould produce a__class__oftypes.UnionTypePeople might rely on that, so no need to break this.