Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.10] gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423) #125106

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

miss-islington
Copy link
Contributor

gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423)

Use a longer key: FIPS mode requires at least of at least 112 bits.
The previous key was only 32 bits.
(cherry picked from commit e091b9f)

(cherry picked from commit f7bfac4)

Co-authored-by: Miss Islington (bot) [email protected]
Co-authored-by: Victor Stinner [email protected]

…pythonGH-109423) (pythonGH-109427)

pythongh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (pythonGH-109423)

Use a longer key: FIPS mode requires at least of at least 112 bits.
The previous key was only 32 bits.
(cherry picked from commit e091b9f)

(cherry picked from commit f7bfac4)

Co-authored-by: Miss Islington (bot) <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Oct 8, 2024
@encukou encukou changed the title [3.10] [3.11] gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423) (GH-109427) [3.10] gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423) Oct 8, 2024
@encukou
Copy link
Member

encukou commented Oct 8, 2024

See gh-125112 for the macOS CI failure.

@encukou encukou marked this pull request as draft October 8, 2024 14:12
@encukou
Copy link
Member

encukou commented Oct 9, 2024

!buildbot FIPS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 1a719bf 🤖

The command will test the builders whose names match following regular expression: FIPS

The builders matched are:

  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR
  • AMD64 CentOS9 FIPS No Builtin Hashes PR

@encukou encukou marked this pull request as ready for review October 10, 2024 11:41
@encukou
Copy link
Member

encukou commented Oct 10, 2024

Note that we care about Only Blake2 builds, which passed here.
The red No Builtin Hashes FIPS builds are unstable and never passed.

@pablogsal pablogsal merged commit e44b32f into python:3.10 Oct 22, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants