Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-125633: Add function ispackage to stdlib inspect #125634

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

gh-125633: Add function ispackage to stdlib inspect #125634

wants to merge 14 commits into from
+37 −6

Conversation

Xiaokang2022
Copy link
Contributor

@Xiaokang2022 Xiaokang2022 commented Oct 17, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 17, 2024
Open
nineteendo
nineteendo reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@nineteendo nineteendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests and fix the sphinx markup?

Misc/NEWS.d/next/Library/2024-10-17-04-52-00.gh-issue-125633.lMck06.rst Outdated Show resolved Hide resolved
@Wulian233
Copy link
Contributor

Please add a unittest and document.

Also add to 3.14 what's new(recommend)

@tomasr8
Copy link
Member

tomasr8 commented Oct 17, 2024

One of the tests is currently failing because you also need to add the new test folder to the Makefile:

cpython/Makefile.pre.in

Line 2500 in 7b04496

test/test_inspect \

should be:

  test/test_inspect \
+ test/test_inspect/inspect_simple_pkg \

@Xiaokang2022 Xiaokang2022 changed the title gh-125633: Adding function ispackage to stdlib inspect gh-125633: Add function ispackage to stdlib inspect Oct 17, 2024
@Wulian233
Copy link
Contributor

LGTM

vstinner
vstinner approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Doc/library/inspect.rst Show resolved Hide resolved
vstinner
vstinner reviewed Oct 17, 2024
View reviewed changes
Doc/library/inspect.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
Eclips4
Eclips4 reviewed Oct 17, 2024
View reviewed changes
Lib/inspect.py Outdated Show resolved Hide resolved
Eclips4
Eclips4 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vstinner
Copy link
Member

@brettcannon @ncoghlan: Is it the correct way to check if a module a package, ismodule(object) and hasattr(object, "__path__")?

sobolevn
sobolevn reviewed Oct 19, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Several comments :)

Lib/test/test_inspect/test_inspect.py Show resolved Hide resolved
Lib/test/test_inspect/test_inspect.py Outdated Show resolved Hide resolved
Makefile.pre.in Outdated Show resolved Hide resolved
@erlend-aasland erlend-aasland removed their request for review October 21, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@sobolevn sobolevn sobolevn left review comments

@nineteendo nineteendo nineteendo left review comments

@Wulian233 Wulian233 Wulian233 approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Xiaokang2022 @Wulian233 @tomasr8 @vstinner @sobolevn @nineteendo @Eclips4