Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-125515: Reduce number of compiler warnings in generated code #125697

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-125515: Reduce number of compiler warnings in generated code #125697

wants to merge 1 commit into from
+11 −8

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Oct 18, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 18, 2024
Open
sobolevn
sobolevn approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this make several warnings to go away!

Tools/cases_generator/tier2_generator.py
@@ -64,6 +64,7 @@ def declare_variables(uop: Uop, out: CWriter) -> None:


class Tier2Emitter(Emitter):

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks unrelated :)

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
awaiting merge skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markshannon @sobolevn