-
-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-119786: move interpreter doc from devguide to InternalDocs #125715
Conversation
7148b3c
to
d65ee0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iritkatriel. I love that the internals docs are next to the code 😄
InternalDocs/interpreter.md
Outdated
Recall that the [Python Compiler](https://github.com/python/cpython/blob/main/InternalDocs/compiler.md) | ||
produces a [`CodeObject`](https://github.com/python/cpython/blob/main/InternalDocs/code_object.md), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might be able to get away with just this (also applies to a bunch of other links in this PR):
Recall that the [Python Compiler](https://github.com/python/cpython/blob/main/InternalDocs/compiler.md) | |
produces a [`CodeObject`](https://github.com/python/cpython/blob/main/InternalDocs/code_object.md), | |
Recall that the [Python Compiler](compiler.md) produces a [`CodeObject`](code_object.md), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I could also use relative links to the code (like ../Python/bytecodes.c
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A couple of minor things I spotted:
Co-authored-by: Jacob Coffee <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
🚢 |
Reorganised index:
https://github.com/python/cpython/blob/7cb14417f5609f75ab484bc81885930158317336/InternalDocs/README.md
Interpreter doc:
https://github.com/python/cpython/blob/7cb14417f5609f75ab484bc81885930158317336/InternalDocs/interpreter.md